Ensure HighLevelGraph layers are Layer instances#5271
Merged
dcherian merged 2 commits intopydata:masterfrom May 6, 2021
Merged
Ensure HighLevelGraph layers are Layer instances#5271dcherian merged 2 commits intopydata:masterfrom
HighLevelGraph layers are Layer instances#5271dcherian merged 2 commits intopydata:masterfrom
Conversation
andersy005
approved these changes
May 6, 2021
Member
andersy005
left a comment
andersy005
left a comment
There was a problem hiding this comment.
Thank you for addressing this issue, @jrbourbeau!
It appears that the failing tests are unrelated to your changes
Contributor
|
Great thanks @jrbourbeau |
dcherian
added a commit
to TomNicholas/xarray
that referenced
this pull request
May 13, 2021
* upstream/master: combine keep_attrs and combine_attrs in apply_ufunc (pydata#5041) Explained what a deprecation cycle is (pydata#5289) Code cleanup (pydata#5234) FacetGrid docstrings (pydata#5293) Add whats new for dataset interpolation with non-numerics (pydata#5297) Allow dataset interpolation with different datatypes (pydata#5008) Flexible indexes: add Index base class and xindexes properties (pydata#5102) pre-commit: autoupdate hook versions (pydata#5280) convert the examples for apply_ufunc to doctest (pydata#5279) fix the new whatsnew section Ensure `HighLevelGraph` layers are `Layer` instances (pydata#5271)
dcherian
added a commit
to matzegoebel/xarray
that referenced
this pull request
May 13, 2021
* upstream/master: (23 commits) combine keep_attrs and combine_attrs in apply_ufunc (pydata#5041) Explained what a deprecation cycle is (pydata#5289) Code cleanup (pydata#5234) FacetGrid docstrings (pydata#5293) Add whats new for dataset interpolation with non-numerics (pydata#5297) Allow dataset interpolation with different datatypes (pydata#5008) Flexible indexes: add Index base class and xindexes properties (pydata#5102) pre-commit: autoupdate hook versions (pydata#5280) convert the examples for apply_ufunc to doctest (pydata#5279) fix the new whatsnew section Ensure `HighLevelGraph` layers are `Layer` instances (pydata#5271) New whatsnew section Release-workflow: Bug fix (pydata#5273) more maintenance on whats-new.rst (pydata#5272) v0.18.0 release highlights (pydata#5266) Fix exception when display_expand_data=False for file-backed array. (pydata#5235) Warn ignored keep attrs (pydata#5265) Disable workflows on forks (pydata#5267) fix the built wheel test (pydata#5270) pypi upload workflow maintenance (pydata#5269) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates how we construct the
HighLevelGraphinsubset_dataset_to_block. Currently we create aHighLevelGraphand then manually add a few new layers, which aredicts, directly tohlg.layers.xarray/xarray/core/parallel.py
Lines 537 to 546 in eec2b59
However since (in more recent versions of Dask)
HighLevelGraphlayers are expected to beLayerclass instances this can result in unexpected errors (xref #5077 (comment)). Instead of manually adding new layers tohlg.layers, this PR proposes we create a newHighLevelGraphaltogether to ensure thathlg.layerswon't contain any rawdictlayers.