Skip to content

Conversation

@Neugeniko
Copy link
Contributor

@Neugeniko Neugeniko commented Mar 16, 2018

This fixes the reported sustainable tank for AAR and ASB. Resolves #1439 when used with the new capsim.

I did this fix in eso/savedata/fit.py. You can do it in effects but that involves overwriting the peak (reinforced) repair figures which I think should be shown all the time as the actual peak. If extrattributes were put in to hold sustained values then you could do the fix in effects without any down side.

Anyway have a play and see if it breaks. Comment welcome.

@codecov-io
Copy link

codecov-io commented Mar 17, 2018

Codecov Report

Merging #1494 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1494      +/-   ##
==========================================
- Coverage   15.77%   15.76%   -0.01%     
==========================================
  Files        2379     2379              
  Lines       34601    34622      +21     
==========================================
  Hits         5457     5457              
- Misses      29144    29165      +21

@blitzmann
Copy link
Collaborator

Looks correct to me. If you don't mind, I'll be pinging you if we get issues popping up about the cap stuff, since I've always looked at it going @_@. But what are doing here makes sense. :)

@blitzmann blitzmann merged commit 2005d0b into pyfa-org:master Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Factor in reload time when calculating capacitor usage, damage and tank appears inaccurate for tank.

3 participants