Skip to content

Use Github Actions for building Wheels and not Travis#197

Merged
lazka merged 2 commits intopygobject:masterfrom
naveen521kk:gh-wheels
Sep 4, 2020
Merged

Use Github Actions for building Wheels and not Travis#197
lazka merged 2 commits intopygobject:masterfrom
naveen521kk:gh-wheels

Conversation

@naveen521kk
Copy link
Copy Markdown
Contributor

This PR is:

TODO:

  • Correct it to upload to releases.

cc
@stuaxo

@stuaxo
Copy link
Copy Markdown
Collaborator

stuaxo commented Sep 1, 2020

I'll test the WHLs this evening (BST), with a view to giving a +1 to releasing them.

@naveen521kk
Copy link
Copy Markdown
Contributor Author

Atleast we can this as whole without follow up PR @stuaxo

@naveen521kk
Copy link
Copy Markdown
Contributor Author

naveen521kk commented Sep 1, 2020

The logic for uploading release is weird for me. What would you like to do? Like tell me the workflow how you want it to be? @stuaxo and @lazka
Also, is the release ready? @stuaxo

@stuaxo
Copy link
Copy Markdown
Collaborator

stuaxo commented Sep 1, 2020

Also, is the release ready? @stuaxo

Yeah, I think we can release the WHLs generated here, are good
https://github.com/naveen521kk/pycairo/actions/runs/234172269

I tested one on a fresh python install (that had never compiled pycairo), to be sure + all the tests pass.

The logic for uploading release is weird for me. What would you like to do? Like tell me the workflow how you want it to be? @stuaxo and @lazka

These are good questions, I don't have answers without having some time to think + learn a bit more about workflows, maybe @lazka has some ideas.

If we move to actions, we should aim not to add too much complexity, adhering to DRY if possible.

This github actions example from cibuildwheel is pretty minimal + in a declarative style.
https://www.fromkk.com/posts/using-cibuildwheel-to-create-python-wheels/

@naveen521kk
Copy link
Copy Markdown
Contributor Author

@lazka so can you or @lazka can release the wheels in PyPi?

@lazka lazka merged commit aa658f4 into pygobject:master Sep 4, 2020
@lazka
Copy link
Copy Markdown
Member

lazka commented Sep 4, 2020

GHA is much better, thanks!

@naveen521kk naveen521kk deleted the gh-wheels branch September 5, 2020 04:03
@naveen521kk
Copy link
Copy Markdown
Contributor Author

@lazka Can you upload the wheels to PyPI?

@lazka
Copy link
Copy Markdown
Member

lazka commented Sep 5, 2020

@naveen521kk I'll do it for the next release. ok?

@naveen521kk
Copy link
Copy Markdown
Contributor Author

I think it would be good if you do for this release itself( Many are in need of it) . Just upload it and PyPi handles it. But yes you would need to run actions by changing the version in setup.py to 19.1.
If you could tell many when next release it would be good if you couldn't upload for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide Windows Wheels

3 participants