Test and hard delayed response test.#2636
Merged
Merged
Conversation
janiversen
added a commit
that referenced
this pull request
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A discussion in HomeAssistant detected un unreported issue, see home-assistant/core/138077
This PR focus on testing and harden the detection of delayed responses. The PR will be part of an upcoming v3.9.2
RTU Frames do not have any transaction ID, making it extra difficult to detect delayed responses, see the following examples
The last example can only be avoided with a sufficiently large timeout !!!!
TCP/TLS Frames have a transaction ID, making it easy to detect delayed responses, see the following examples
In general a timeout need to be sufficient large to e.g. allow a temporary dropout, typically 1-2 minutes. Please be aware that a large timeout, permits "good" requests to work efficiently, and only affects "bad" requests.