Skip to content

make base frame signature match subclasses#2726

Merged
janiversen merged 2 commits into
devfrom
base-framer
Aug 8, 2025
Merged

make base frame signature match subclasses#2726
janiversen merged 2 commits into
devfrom
base-framer

Conversation

@alexrudd2
Copy link
Copy Markdown
Collaborator

Simple method call signature cleanup.

Currently FramerBase and FramerAscii use the parameter data: bytes, and the others use pdu: bytes. pdu is more descriptive.

Copy link
Copy Markdown
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, THANKS.

@alexrudd2
Copy link
Copy Markdown
Collaborator Author

Credit to pyright here; it catches different things than mypy. But there are ~40 errors remaining with the default settings, and some of them are false positives.

@janiversen janiversen merged commit 6387f54 into dev Aug 8, 2025
@janiversen janiversen deleted the base-framer branch August 8, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants