Fix CSS lookup for simulator server#2904
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CSS lookup when running
pymodbus.simulator.Currently, the pymodbus simulator fails to load CSS:
Before
With this change, I observe CSS loading:
After
Background
I can confirm that I observed a 404 on the
pymodbus_styles.css:in both Chrome and Firefox.
I suspect that this regex will only serve files that contain the characters:
a-z(lowercase letters)0-9(digits).(any number of)I did confirm that an alternative solution would work:
pymodbus_styles.cssreferences topymodbusstyles.csspymodbusstyles.cssThis removes the
_, allowing the existing regex to work. However, I proposed what I feel is a more light-weight solution: extending the regex.