Reliably find uv binary#347
Merged
Merged
Conversation
ryanking13
reviewed
May 18, 2026
Member
ryanking13
left a comment
There was a problem hiding this comment.
Thanks. So one difference this makes is that when there is uv installed, now we will always use uv, while previously, we used uv only when the pyodide entrypoint was invoked with uv (therefore the UV env variable is set).
I think it should be okay, but it would be worth to mention.
Member
Author
|
Yes, correct. The errors I was facing were of the type where the cross-build packages were trying to be installed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made our uv helper match what cibuildwheel does to find uv. There's not much of a difference, but I've frequently run into issues with this when developing locally on my macOS machine and it might have been due to the functools cache for all we know.
Also, complies wth PEP 639 and fixes our licensing metadata.