Skip to content

Reliably find uv binary#347

Merged
agriyakhetarpal merged 3 commits into
mainfrom
reliably-find-uv
May 18, 2026
Merged

Reliably find uv binary#347
agriyakhetarpal merged 3 commits into
mainfrom
reliably-find-uv

Conversation

@agriyakhetarpal
Copy link
Copy Markdown
Member

I made our uv helper match what cibuildwheel does to find uv. There's not much of a difference, but I've frequently run into issues with this when developing locally on my macOS machine and it might have been due to the functools cache for all we know.

Also, complies wth PEP 639 and fixes our licensing metadata.

@agriyakhetarpal agriyakhetarpal added the integration This PR will run the integration tests. This label can be used as a persistent marker to do so. label May 18, 2026
@agriyakhetarpal agriyakhetarpal merged commit d16700b into main May 18, 2026
26 checks passed
@agriyakhetarpal agriyakhetarpal deleted the reliably-find-uv branch May 18, 2026 12:57
Copy link
Copy Markdown
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. So one difference this makes is that when there is uv installed, now we will always use uv, while previously, we used uv only when the pyodide entrypoint was invoked with uv (therefore the UV env variable is set).

I think it should be okay, but it would be worth to mention.

@agriyakhetarpal
Copy link
Copy Markdown
Member Author

Yes, correct. The errors I was facing were of the type where the cross-build packages were trying to be installed with pip in a uv-managed environment, but in such venvs the pip entry point does not exist deliberately and only uv pip works. I think it also makes expectations clearer, since we would expect that someone installing pyodide-build[uv] would want to use uv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration This PR will run the integration tests. This label can be used as a persistent marker to do so.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants