Merged
Conversation
Member
|
We're still using |
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
for more information, see https://pre-commit.ci
henryiii
force-pushed
the
henryiii/fix/quiet
branch
from
e47c0f0 to
e9a124b
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
henryiii
force-pushed
the
henryiii/fix/quiet
branch
from
e9a124b to
b94ba1e
Compare
henryiii
requested review from
agriyakhetarpal,
freakboy3742,
hoodmane,
mhsmith and
ryanking13
as code owners
Contributor
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
The changes for iOS make sense to me,
More generally, the only question I'd have is whether we actually want to retain support for Python 3.8 at all...
Contributor
Author
|
I think we plan to drop it in May |
agriyakhetarpal
approved these changes
Feb 11, 2026
Contributor
Author
|
@mayeut the last commit here can be reverted when we drop Python 3.8! |
Member
|
I rebased the drop 3.8 PR & removed the workaround introduced here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build now supports this in 1.4.0, and uv does too.