Ignore --require-virtualenv for check and freeze commands#12842
Conversation
pradyunsg
approved these changes
Jul 11, 2024
ichard26
approved these changes
Jul 11, 2024
Member
ichard26
left a comment
ichard26
left a comment
There was a problem hiding this comment.
It does indeed work, thank you!
Member
|
Ah of course CI is failing because of the flaky tests I introduced. When I come back to the computer in ~two hours, I'll fixup #12839. Sorry about that! |
Contributor
Author
|
no worries, thank you both for all your hard work on pip :) |
Member
|
@branchvincent could you merge in or rebase on main to pull in the CI fixes that just landed? TIA |
pradyunsg
approved these changes
Jul 13, 2024
Member
|
Thanks @branchvincent! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since these are read-only commands (like
pip list)