Merged
Conversation
Contributor
Author
|
Closes #760 |
NdagiStanley
changed the title
uranusjr
approved these changes
Nov 16, 2021
gaborbernat
force-pushed
the
main
branch
9 times, most recently
from
ba1004d to
9f9271b
Compare
gaborbernat
requested changes
Jan 2, 2022
Contributor
gaborbernat
left a comment
gaborbernat
left a comment
There was a problem hiding this comment.
Merge conflicts need to be resolved.
* Fix python 3.6-3.8 compatability error All PR CI checks are currently failing because a method call was added to the `pipx.commands.reinstall.reinstall` function which was only added in python 3.9 Replaced that method call with a python >=3.6 workaround * fixed formatting to black's satisfaction Co-authored-by: Alex Tremblay <alex@tremblay.in>
NdagiStanley
force-pushed
the
edit-link
branch
from
23af4bc to
a5a3c91
Compare
Contributor
Author
|
@gaborbernat I've resolved the merge conflicts. This can be added to the |
gaborbernat
reviewed
Jan 3, 2022
Comment on lines
+31
to
+38
| # use PurePath.relative_to in a try block instead | ||
| # of PurePath.is_relative_to, for python 3.6-3.8 compatability | ||
| Path(python).relative_to(venv_dir) | ||
| python_relative_to_venv_dir = True | ||
| except ValueError: | ||
| pass | ||
| else: | ||
| python_relative_to_venv_dir = False | ||
|
|
||
| if python_relative_to_venv_dir: |
Contributor
There was a problem hiding this comment.
This change seems unrelated, what happened here?
Contributor
There was a problem hiding this comment.
I've reverted the PR to avoid merging this. Please open a new PR and keep the change set scopped to the PR description.
gaborbernat
added a commit
that referenced
this pull request
Jan 3, 2022
This reverts commit 9d24fb9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdSummary of changes
mkdocs.ymlto includeReference: MkDocs User guide configuration page
Test plan
Tested by running the following in a python virtual environment:
The updated docs can be viewed at http://127.0.0.1:8000/. Click on the pencil icon towards the top right part of the page and confirm that the link redirects to [this page].(https://github.com/pypa/pipx/edit/main/docs/index.md)