Produce correct ABI tags for GraalPy#557
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
+ Coverage 72.35% 72.61% +0.26%
==========================================
Files 13 13
Lines 1085 1088 +3
==========================================
+ Hits 785 790 +5
+ Misses 300 298 -2
☔ View full report in Codecov by Sentry. |
Member
|
@msimacek, can you add a test for this please ? |
Contributor
|
Testing could be difficult as the |
Member
|
This can be done with mocking like it is with PyPy: wheel/tests/test_bdist_wheel.py Lines 294 to 297 in 2bf5bb0 |
c079363 to
a28bc2c
Compare
73a5a57 to
bca1384
Compare
for more information, see https://pre-commit.ci
Contributor
Author
|
I added a test |
Contributor
|
Please add a note to the changelog ( |
Contributor
Author
Added, thank you for assistance. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pypa/packaging#607 changed the ABI tag computation for GraalPy. This results in the current wheel not working for GraalPy because it uses pypa/packaging to validate tags of newly built wheels and now it always rejects them as mismatched. We need a corresponding change in wheel's tag computation, like it was done for PyPy in #373. Our SOABI look something like
graalpy231-310-native-x86_64-linux, so the expected ABI tag for that isgraalpy231_310_native. Compared to PyPy's there is one more component to distinguish native and sandboxed modes.CC @timfel