Add PHP versions 8.3, 8.4, and 8.5 to CI matrix#84
Merged
pyrech merged 6 commits intopyrech:mainfrom Nov 27, 2025
Merged
Conversation
Contributor
Author
|
@pyrech |
AlexSkrypnyk
commented
Nov 26, 2025
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@v6 |
Contributor
Author
There was a problem hiding this comment.
v2 no longer supported and does not run in GHA
AlexSkrypnyk
commented
Nov 26, 2025
| name: [''] | ||
| include: | ||
| - php-version: 7.4 | ||
| - php-version: 8.1 |
Contributor
Author
There was a problem hiding this comment.
lowest are still tested with the lowest version
AlexSkrypnyk
commented
Nov 26, 2025
| composer-flags: '--prefer-lowest' | ||
| name: '(prefer lowest dependencies)' | ||
| - php-version: 8.1 | ||
| - php-version: 8.5 |
Contributor
Author
There was a problem hiding this comment.
highest are still tested with dev
AlexSkrypnyk
commented
Nov 26, 2025
|
|
||
| - name: Cache composer dependencies | ||
| uses: actions/cache@v2 | ||
| uses: actions/cache@v4 |
Contributor
Author
There was a problem hiding this comment.
v2 no longer supported and does not run in GHA
AlexSkrypnyk
commented
Nov 26, 2025
| string $key, | ||
| $default, | ||
| string $additionalMessage = '' | ||
| string $additionalMessage = '', |
AlexSkrypnyk
commented
Nov 26, 2025
| // Sorry for this, I couldn't find any way to get the path of the current root package | ||
| $reflection = new \ReflectionClass($composerConfig); | ||
| $property = $reflection->getProperty('baseDir'); | ||
| $property->setAccessible(true); |
Contributor
Author
There was a problem hiding this comment.
PHP 8.5 deprecation
AlexSkrypnyk
commented
Nov 26, 2025
| } | ||
|
|
||
| public function getOutput(OperationInterface $operation, UrlGenerator $urlGenerator = null): array | ||
| public function getOutput(OperationInterface $operation, ?UrlGenerator $urlGenerator = null): array |
AlexSkrypnyk
commented
Nov 26, 2025
| "composer/composer": "^1.1 || ^2.0", | ||
| "friendsofphp/php-cs-fixer": "^3.0", | ||
| "phpstan/phpstan": "^1.9", | ||
| "symfony/console": "^5.4.11 || ^6.0 || ^7.0", |
Contributor
Author
There was a problem hiding this comment.
5.4 for lowest
Owner
|
Thanks for your PR @AlexSkrypnyk 🎉 I reenabled the CI workflow. Also, could you add a note on the changelog to mention the support removal for PHP < 8.1? |
Contributor
Author
|
@pyrech |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83
This also updates min PHP requirement to 8.1
7.4 is EOL 3 years (https://endoflife.date/php)
Compatibility with 8.4+ required removing some code, which made it incompatible with 7.4