Bring in 3 commits from PyEVTK BitBucket repo and 1 from paulo-herrera/PyEVTK on github#12
Merged
renefritze merged 6 commits intopyscience-projects:masterfrom Mar 17, 2019
xylar:update_from_hererra_pyevtk
Merged
Bring in 3 commits from PyEVTK BitBucket repo and 1 from paulo-herrera/PyEVTK on github#12renefritze merged 6 commits intopyscience-projects:masterfrom xylar:update_from_hererra_pyevtk
renefritze merged 6 commits intopyscience-projects:masterfrom
xylar:update_from_hererra_pyevtk
Conversation
Collaborator
Author
|
This PR is based off of #11, so it shouldn't be merged until after that one. |
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
===========================================
+ Coverage 70.71% 85.14% +14.42%
===========================================
Files 5 5
Lines 519 525 +6
===========================================
+ Hits 367 447 +80
+ Misses 152 78 -74
Continue to review full report at Codecov.
|
Collaborator
Author
|
Wow, I'm really impressed with the CI you've set up! |
Collaborator
That was all @renefritze. He's done a great job :) |
Collaborator
|
I'll review as soon as I get a chance |
somada141
approved these changes
Mar 16, 2019
Collaborator
Author
|
Thanks @renefritze! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As best I can see, these are the relevant commits from these two repos that haven't been mirrored here. The original commits are:
https://bitbucket.org/pauloh/pyevtk/commits/c3c076129dbc6a3bebc801c8929baf9f1d1c74ca
https://bitbucket.org/pauloh/pyevtk/commits/4e759fe42afa605415cbe2e5127112efa7571213 https://bitbucket.org/pauloh/pyevtk/commits/5d22e9cd10a0f67ae4ab3fa6c8cdcc41c7d694a3
paulo-herrera/PyEVTK@823d84a