add scatter_or_line argument to Learner1D.plot#215
Merged
Conversation
Contributor
|
Not sure; we're already using not-a-plotting-library (holoviews), so I'd rather keep adaptive's plotting interface as small as possible. |
jbweston
requested changes
Oct 12, 2019
Contributor
jbweston
left a comment
jbweston
left a comment
There was a problem hiding this comment.
I disagree with anton here. BaseLearner has no plotting method, so any additions we make to the plotting APIs only affect individual learners, and here I think we should make the interface as user-friendly as possible
basnijholt
force-pushed
the
learner1D_plot
branch
from
d1f6dfc to
a24fe9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've needed this many times and the discussion in the chat now also made it clear that this is needed.
Now you won't have to look at plots like this:
