Allow deep_iterable and deep_mapping take lists/tuples #1449
+77
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thx 🎉 |
AdrianSosic
added a commit
to emdgroup/baybe
that referenced
this pull request
Jul 29, 2025
AdrianSosic
added a commit
to emdgroup/baybe
that referenced
this pull request
Oct 7, 2025
AdrianSosic
added a commit
to emdgroup/baybe
that referenced
this pull request
Oct 7, 2025
Now fixed upstream in the new `attrs` version. * python-attrs/attrs#1448 * python-attrs/attrs#1449
luketainton
pushed a commit
to luketainton/repos_pypilot
that referenced
this pull request
Jan 5, 2026
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [attrs](https://github.com/python-attrs/attrs) ([changelog](https://www.attrs.org/en/stable/changelog.html)) | `==25.3.0` -> `==25.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>python-attrs/attrs (attrs)</summary> ### [`v25.4.0`](https://github.com/python-attrs/attrs/blob/HEAD/CHANGELOG.md#2540---2025-10-06) [Compare Source](python-attrs/attrs@25.3.0...25.4.0) ##### Backwards-incompatible Changes - Class-level `kw_only=True` behavior is now consistent with `dataclasses`. Previously, a class that sets `kw_only=True` makes all attributes keyword-only, including those from base classes. If an attribute sets `kw_only=False`, that setting is ignored, and it is still made keyword-only. Now, only the attributes defined in that class that doesn't explicitly set `kw_only=False` are made keyword-only. This shouldn't be a problem for most users, unless you have a pattern like this: ```python @​attrs.define(kw_only=True) class Base: a: int b: int = attrs.field(default=1, kw_only=False) @​attrs.define class Subclass(Base): c: int ``` Here, we have a `kw_only=True` *attrs* class (`Base`) with an attribute that sets `kw_only=False` and has a default (`Base.b`), and then create a subclass (`Subclass`) with required arguments (`Subclass.c`). Previously this would work, since it would make `Base.b` keyword-only, but now this fails since `Base.b` is positional, and we have a required positional argument (`Subclass.c`) following another argument with defaults. [#​1457](python-attrs/attrs#1457) ##### Changes - Values passed to the `__init__()` method of `attrs` classes are now correctly passed to `__attrs_pre_init__()` instead of their default values (in cases where *kw\_only* was not specified). [#​1427](python-attrs/attrs#1427) - Added support for Python 3.14 and [PEP 749](https://peps.python.org/pep-0749/). [#​1446](python-attrs/attrs#1446), [#​1451](python-attrs/attrs#1451) - `attrs.validators.deep_mapping()` now allows to leave out either *key\_validator* xor *value\_validator*. [#​1448](python-attrs/attrs#1448) - `attrs.validators.deep_iterator()` and `attrs.validators.deep_mapping()` now accept lists and tuples for all validators and wrap them into a `attrs.validators.and_()`. [#​1449](python-attrs/attrs#1449) - Added a new **experimental** way to inspect classes: `attrs.inspect(cls)` returns the *effective* class-wide parameters that were used by *attrs* to construct the class. The returned class is the same data structure that *attrs* uses internally to decide how to construct the final class. [#​1454](python-attrs/attrs#1454) - Fixed annotations for `attrs.field(converter=...)`. Previously, a `tuple` of converters was only accepted if it had exactly one element. [#​1461](python-attrs/attrs#1461) - The performance of `attrs.asdict()` has been improved by 45–260%. [#​1463](python-attrs/attrs#1463) - The performance of `attrs.astuple()` has been improved by 49–270%. [#​1469](python-attrs/attrs#1469) - The type annotation for `attrs.validators.or_()` now allows for different types of validators. This was only an issue on Pyright. [#​1474](python-attrs/attrs#1474) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzYuMCIsInVwZGF0ZWRJblZlciI6IjQxLjEzNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/pypilot/pulls/381 Co-authored-by: renovate[bot] <[email protected]> Co-committed-by: renovate[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1243
doesn't it @AdrianSosic?