Skip to content

change initialize_problem to require keyword args #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zingale merged 5 commits into from
Sep 4, 2024
Merged

change initialize_problem to require keyword args #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4855de6
change initialize_problem to require keyword args
zingale Sep 4, 2024
0d1b883
fix args
zingale Sep 4, 2024
637197b
update notebooks
zingale Sep 4, 2024
d99a385
update interface
zingale Sep 4, 2024
ec2b17b
update notebook
zingale Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions examples/examples.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"outputs": [],
"source": [
"pyro_sim = Pyro(solver)\n",
"pyro_sim.initialize_problem(problem_name, param_file)"
"pyro_sim.initialize_problem(problem_name, inputs_file=param_file)"
]
},
{
Expand Down Expand Up @@ -198,13 +198,13 @@
},
{
"cell_type": "code",
"execution_count": 9,
"execution_count": 8,
"metadata": {},
"outputs": [],
"source": [
"# NBVAL_IGNORE_OUTPUT \n",
"extra_parameters = {'vis.dovis': False, 'mesh.nx': 8, 'mesh.ny':8, 'particles.do_particles': False}\n",
"pyro_sim.initialize_problem(problem_name, param_file, inputs_dict=extra_parameters)\n",
"pyro_sim.initialize_problem(problem_name, inputs_file=param_file, inputs_dict=extra_parameters)\n",
"pyro_sim.run_sim;"
]
},
Expand All @@ -217,7 +217,7 @@
},
{
"cell_type": "code",
"execution_count": 10,
"execution_count": 9,
"metadata": {
"tags": [
"nbval-ignore-output"
Expand Down Expand Up @@ -257,7 +257,7 @@
},
{
"cell_type": "code",
"execution_count": 11,
"execution_count": 10,
"metadata": {},
"outputs": [],
"source": [
Expand All @@ -266,7 +266,7 @@
},
{
"cell_type": "code",
"execution_count": 12,
"execution_count": 11,
"metadata": {
"tags": []
},
Expand Down Expand Up @@ -340,7 +340,7 @@
},
{
"cell_type": "code",
"execution_count": 13,
"execution_count": 12,
"metadata": {},
"outputs": [
{
Expand Down
61 changes: 7 additions & 54 deletions presentations/pyro_intro.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pyro/pyro_sim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def __init__(self, solver_name, from_commandline=False):

self.is_initialized = False

def initialize_problem(self, problem_name, inputs_file=None, inputs_dict=None,
def initialize_problem(self, problem_name, *, inputs_file=None, inputs_dict=None,
other_commands=None):
"""
Initialize the specific problem
Expand Down
Loading