PR: Rename namespace to pylsp and package to python-lsp-server #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Apr 10, 2021
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks a lot @andfoy for this! It looks pretty good to me, except for some minor issues.
ccordoba12
changed the title
bnavigator
reviewed
Apr 10, 2021
bnavigator
reviewed
Apr 10, 2021
bnavigator
reviewed
Apr 10, 2021
ccordoba12
approved these changes
Apr 12, 2021
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks a lot for this @andfoy! Looks good to me now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also migrates the package to support Python 3.6+ only.
See #4