Skip to content

Fix indices of colors read from GIMP Palette file #6640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsbueno wants to merge 20 commits into from
Closed

Fix indices of colors read from GIMP Palette file #6640

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
61b1eeb
Fix indices of colors read from GIMP Palette file
jsbueno Oct 4, 2022
d0837bd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 4, 2022
681f77a
Linter fixes, remove hanging unused lambda
jsbueno Oct 4, 2022
4642e02
Only use colors from the palette file
radarhere Oct 6, 2022
1ed6039
Merge pull request #1 from radarhere/gimppalette
jsbueno Oct 6, 2022
a12389b
Provide way to load big palettes;
jsbueno Oct 6, 2022
2f6467c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 6, 2022
b471158
:lipstick:
jsbueno Oct 6, 2022
0d00d08
Remove n_colors property
jsbueno Oct 7, 2022
2eb6976
Update src/PIL/GimpPaletteFile.py
jsbueno Oct 7, 2022
c345080
Update Tests/test_file_gimppalette.py
jsbueno Oct 7, 2022
378471e
Mark 'break' after 'warning' as not "no cover": testing promotes the …
jsbueno Oct 9, 2022
8979f0c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 9, 2022
e007a0b
Improved test
radarhere Oct 11, 2022
6893d1d
Merge pull request #3 from radarhere/gimppalette_test
jsbueno Oct 12, 2022
cefeab8
Use array for better performance
radarhere Nov 5, 2022
ea271be
Merge branch 'main' into fix/gimppalette
radarhere Dec 30, 2022
9239820
Merge branch 'main' into fix/gimppalette
radarhere Mar 19, 2025
c7e70d5
Added type hint
radarhere Mar 19, 2025
dee9336
Use monkeypatch
radarhere Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/PIL/GimpPaletteFile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class GimpPaletteFile:
#: override if reading larger palettes is needed
max_colors = 256
_max_line_size = 100
Copy link
Copy Markdown
Member

@radarhere radarhere Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're reading RGB data from each line. That's three integers. Under what circumstances would a user need to read more than 100 characters?

Copy link
Copy Markdown
Contributor Author

@jsbueno jsbueno Oct 7, 2022 •
edited by radarhere
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 4th Column contains the color name, though that is currently unused. And there might be a name with more than 100 characters - moving the number to an attribute just offers a chance of one working around an error imposed by an arbitrary, though reasonable, limit on an otherwise good file.

Copy link
Copy Markdown
Contributor Author

@jsbueno jsbueno Oct 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(currently unused in PIL, that is: GIMP uses that name)

_max_file_size = 2**20
_max_file_size = 2 ** 20 # 1MB

def __init__(self, fp):

Expand All @@ -49,7 +49,7 @@ def __init__(self, fp):
warnings.warn(
f"Palette file truncated at {self._max_file_size - len(s)} bytes"
)
break
break # pragma: no cover
Comment thread
radarhere marked this conversation as resolved.
Outdated

# skip fields and comment lines
if re.match(rb"\w+:|#", s):
Expand Down