Workaround OpenSSL 1.1.1 session-ticket issue#1171
Workaround OpenSSL 1.1.1 session-ticket issue#1171oremanj merged 5 commits intopython-trio:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
- Coverage 99.55% 92.62% -6.94%
==========================================
Files 106 106
Lines 12751 12767 +16
Branches 978 980 +2
==========================================
- Hits 12694 11825 -869
- Misses 36 877 +841
- Partials 21 65 +44
|
|
The remaining test failure should be fixed by #1172 |
|
Not sure why codecov isn't updating its comment. If you click through then it says that everything is covered. |
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
The change appears to implement your heuristic but I don't feel qualified enough to approve, sorry!
|
|
||
| # This uses serve_ssl_over_tcp, which uses open_ssl_over_tcp_listeners... | ||
| async def test_open_ssl_over_tcp_stream_and_everything_else(): | ||
| # noqa is needed because flake8 doesn't understand how pytest fixtures work. |
There was a problem hiding this comment.
I think you can fix the flake8 issue by removing the unused client_ctx import
There was a problem hiding this comment.
It's not unused, it's making the fixture function visible to pytest...
There was a problem hiding this comment.
Sorry about that, I'm used to projects where pytest discovers the fixtures through conftest.py
|
I'm a big fan of the analysis on #819 - thank you for fixing this! |
3 participants
Fixes #819