Conversation
The only thing left missing is aclosing() on Python < 3.10 which is now provided by contextlib2.
Codecov Report
@@ Coverage Diff @@
## master #2212 +/- ##
==========================================
- Coverage 99.57% 99.38% -0.20%
==========================================
Files 114 114
Lines 14731 14724 -7
Branches 2334 2335 +1
==========================================
- Hits 14669 14634 -35
- Misses 41 70 +29
+ Partials 21 20 -1
|
|
While it makes sense to stop depending on |
|
I suppose so. I will restore the tests. |
We cannot drop async_generator and continue to support it at the same time. That is the inconvenient truth. Here is the line that makes all the difference. |
|
I think we need a change in strategy: Deprecate |
|
Agreed. In any case this means we can close this pull request. |
This removes all uses of
async_generator, replacing it with contextlib2 in the cases whereaclosing()is needed, and then only on Python < 3.10.This depends on #2210.