Conversation
Pull request was closed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3363 +/- ##
====================================================
- Coverage 100.00000% 99.98969% -0.01032%
====================================================
Files 125 125
Lines 19388 19391 +3
Branches 1319 1320 +1
====================================================
+ Hits 19388 19389 +1
- Misses 0 1 +1
- Partials 0 1 +1
🚀 New features to boost your workflow:
|
|
Bumping Sphinx isn't actually going to work, looks like our sphinxcontrib_trio isn't really compatible with Sphinx 9 after they rewrote autodoc. There's an option to use the old code still which would probably make it work temporarily, but we might need to redo that module. |
|
|
||
| if tool == "mypy" and sys.implementation.name != "cpython": | ||
| # https://github.com/python/mypy/issues/20329 | ||
| pytest.skip("mypy does not support pypy") |
There was a problem hiding this comment.
@A5rocks @CoolCat467 this caused one line below to become uncovered:
https://app.codecov.io/gh/python-trio/trio/commit/0ae6e622fb618ca833a6106dedb1aed4884ca94a/blob/src/trio/_tests/test_exports.py?dropdown=coverage#L370
There was a problem hiding this comment.
Ack, why didn't that show up as a status for the PR! (or maybe I missed it :/)
No description provided.