Skip to content

Fix missing and redundant and imports in __init__#1029

Merged
ocefpaf merged 1 commit into
python-visualization:masterfrom
Conengmo:fix-init-imports
Nov 27, 2018
Merged

Fix missing and redundant and imports in __init__#1029
ocefpaf merged 1 commit into
python-visualization:masterfrom
Conengmo:fix-init-imports

Conversation

@Conengmo

Copy link
Copy Markdown
Member

In #1017 the import of GeoJsonTooltip got accidently removed from __init__.py. This PR restores it.

I also removed three unused entries in the __all__ list: GeoJsonStyle and Polyline don't exist (PolyLine does though). MarkerCluster is a plugin.

Once this PR is merged we can continue with #988.

@Conengmo Conengmo requested a review from ocefpaf November 25, 2018 17:56
@Conengmo Conengmo added the waiting for review PR is waiting to be reviewed label Nov 25, 2018
Comment thread folium/__init__.py

@ocefpaf ocefpaf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor question and this is good to go.

@Conengmo Conengmo added in discussion This PR or issue is being discussed and removed waiting for review PR is waiting to be reviewed labels Nov 26, 2018
@ocefpaf ocefpaf merged commit 9b68b00 into python-visualization:master Nov 27, 2018
@Conengmo Conengmo deleted the fix-init-imports branch November 27, 2018 11:53
@Conengmo Conengmo removed the in discussion This PR or issue is being discussed label Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants