Repository navigation
fix(core): Add missing Zookeeper exceptions codes - #743
Merged
Merged
Conversation
ceache
force-pushed
the
fix/exceptions
branch
from
February 6, 2024 07:10
cb52808 to
d0fd884
Compare
Sync'd up to Zookeeper 3.9.2 error codes.
ceache
force-pushed
the
fix/exceptions
branch
from
February 6, 2024 07:13
d0fd884 to
4c6bad8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
==========================================
+ Coverage 96.76% 96.84% +0.07%
==========================================
Files 27 27
Lines 3557 3549 -8
==========================================
- Hits 3442 3437 -5
+ Misses 115 112 -3 ☔ View full report in Codecov by Sentry. |
Member
|
Nice! Does this relate to #727? |
ceache
marked this pull request as ready for review
February 6, 2024 20:31
Contributor
Author
|
@StephenSorriaux yes! It does resolve #727 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync'd up to Zookeeper 3.9.2 error codes.
Why is this needed?
Server errors with missing error codes are handled poorly and result in connection close.
Proposed Changes
Does this PR introduce any breaking change?
No.