Skip to content

Use underscores instead of spaces in paths #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 8 commits into from
Jul 25, 2024
Merged

Use underscores instead of spaces in paths #332

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
23fcb05
Use dashes instead of spaces in paths
hugovk Mar 28, 2023
f0f2b4f
Test get_misc_news_filename with hyphens and spaces, and reject spaces
hugovk Apr 3, 2023
c75763e
Use underscores instead of dashes for spaces
hugovk Jul 24, 2023
80124cd
Merge remote-tracking branch 'upstream/main' into no-spaces
hugovk Jul 7, 2024
e51ed08
blurb uses underscores not hyphens
hugovk Jul 7, 2024
a64d191
Show spaces but use underscores
hugovk Jul 8, 2024
a68b124
Show spaces but use hyphen
hugovk Jul 8, 2024
16b5c68
Merge branch 'main' into no-spaces
hugovk Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions blurb_it/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@


async def get_misc_news_filename(issue_number, section, body):
if " " in section:
raise ValueError(f"Use underscores not spaces in section name: {section}")
date = time.strftime("%Y-%m-%d-%H-%M-%S", time.localtime())
nonce = await nonceify(body)
path = f"Misc/NEWS.d/next/{section}/{date}.gh-issue-{issue_number}.{nonce}.rst"
Expand Down
4 changes: 2 additions & 2 deletions templates/add_blurb.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ <h3>📜🤖 Blurb it again?</h3>
<select id="section" name="section" class="form-control form-inline" required>
<option></option>
<option>Security</option>
<option>Core and Builtins</option>
<option>Core_and_Builtins</option>
Comment thread
hugovk marked this conversation as resolved.
Outdated
<option>Library</option>
<option>Documentation</option>
<option>Tests</option>
Expand All @@ -47,7 +47,7 @@ <h3>📜🤖 Blurb it again?</h3>
<option>macOS</option>
<option>IDLE</option>
<option>Tools-Demos</option>
Comment thread
hugovk marked this conversation as resolved.
Outdated
<option>C API</option>
<option>C_API</option>
Comment thread
hugovk marked this conversation as resolved.
Outdated
</select>
</div>
</div>
Expand Down
22 changes: 22 additions & 0 deletions tests/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,28 @@ async def test_get_misc_news_filename():
assert path.endswith(".gh-issue-123.Ps4kgC.rst")


async def test_get_misc_news_filename_sections_with_dashes():
path = await util.get_misc_news_filename(
issue_number=123,
section="Core_and_Builtins",
body="Lorem ipsum dolor amet flannel squid normcore tbh raclette enim",
)

assert path.startswith("Misc/NEWS.d/next/Core-and-Builtins/")


async def test_get_misc_news_filename_sections_with_space():
with pytest.raises(
ValueError,
match="Use underscores not spaces in section name: Core and Builtins",
):
await util.get_misc_news_filename(
issue_number=123,
section="Core and Builtins",
body="Lorem ipsum dolor amet flannel squid normcore tbh raclette enim",
)


async def test_has_session():
request = mock_request_session()

Expand Down