-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-102296 Document that inspect.Parameter kinds support ordering #102297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AlexWaygood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like we currently have any tests asserting that the inspect.Parameter kinds support ordering. I'm not sure we should document it if it's untested, as that means that it could break in the future without anybody noticing. Would you be interested in adding a test to https://github.com/python/cpython/blob/main/Lib/test/test_inspect.py as part of this PR?
|
@AlexWaygood I was about to, but actually there is ! cpython/Lib/test/test_inspect.py Lines 3725 to 3726 in e3c3f9f
|
Thanks, not sure how I missed that! |
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
|
Status check is done, and it's a success ✅. |
|
Thanks @Gouvernathor for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-102298 is a backport of this pull request to the 3.11 branch. |
|
GH-102299 is a backport of this pull request to the 3.10 branch. |
Automerge-Triggered-By: GH:AlexWaygood