Update cryptographic CODEOWNERS entry#131892
Merged
gpshead merged 1 commit intopython:mainfrom Mar 30, 2025
Merged
Conversation
gpshead
approved these changes
Mar 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I observed that I wasn't notified automatically when HACL* sources are touched so I'm adding myself to the codeowners.
Note that the
**/sha*pattern also matchedLib/multiprocessing/shared_memory.py, but since Gregory is already an mp-expert, it was probably never noticed (and tiran is no more active). So I'm refining the pattern so that we're only picking up SHA-related files.In addition, I'm adding an entry for SSL-related stuff (@gpshead I added you as well but feel free to edit the PR directly if you don't want to be notified for SSL-related changes).
**/*ssl*picks up quite a lot of files but I think, possibly except forLib/asyncio/sslproto.py, we should be considered code owners (or at least relevant people to tag when modifying such files):NB: I observed that I never added myself to ACKS, so I'm taking this commit as an opporunity as well.
NB2: the reason why we have
Modules/*sha*and notModules/sha*is to also be notified when clinic files are changed for whatever reasons (comparegit ls-files 'Modules/*sha*'andgit ls-files 'Modules/sha*').