gh-139156: Optimize the UTF-7 encoder#139253
Merged
vstinner merged 1 commit intopython:mainfrom Sep 24, 2025
Merged
Conversation
Remove base64SetO and base64WhiteSpace parameters.
Member
Author
These parameters could be set with the old PyUnicode_EncodeUTF7() C API, but this function has been removed: PyObject *
PyUnicode_EncodeUTF7(const Py_UNICODE *s,
Py_ssize_t size,
int base64SetO,
int base64WhiteSpace,
const char *errors) |
Member
Author
|
Benchmark: import pyperf
runner = pyperf.Runner()
sizes = (3, 100, 1_000, 10_000)
for size in sizes:
runner.timeit(f'{size:,} ASCII chars',
setup=f's="x"*{size}',
stmt='s.encode("utf7")')Results:
Note: there is no performance impact on UCS-2 and UCS-4 characters. |
Member
Author
Member
Author
|
Benchmark: import pyperf
runner = pyperf.Runner()
sizes = (1, 100, 10_000)
for size in sizes:
runner.timeit(f'{size:,} ASCII chars',
setup=f's="x"*{size}',
stmt='s.encode("utf7")')Results comparing the 3.14 branch to the main branch:
So even with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove base64SetO and base64WhiteSpace parameters.