Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 3, 2025

  • Remove quadratic behavior in node ID cache clearing

Co-authored-by: Jacob Walls [email protected]

  • Add news fragment

(cherry picked from commit 08d8e18)

Co-authored-by: Seth Michael Larson [email protected]
Co-authored-by: Jacob Walls [email protected]

…ythonGH-142146)

* Remove quadratic behavior in node ID cache clearing

Co-authored-by: Jacob Walls <[email protected]>

* Add news fragment

---------
(cherry picked from commit 08d8e18)

Co-authored-by: Seth Michael Larson <[email protected]>
Co-authored-by: Jacob Walls <[email protected]>
@hugovk
Copy link
Member

hugovk commented Dec 5, 2025

The Android failure is unrelated (some GitHub disk space issue).

But the WASI failure is in this PR's new test:

======================================================================
FAIL: testAppendChildNoQuadraticComplexity (test.test_minidom.MinidomTest.testAppendChildNoQuadraticComplexity)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Lib/test/test_minidom.py", line 192, in testAppendChildNoQuadraticComplexity
    self.assertLess(end - start, 1)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
AssertionError: 2.0126874446868896 not less than 1
----------------------------------------------------------------------
Ran 130 tests in 3.768s
FAILED (failures=1)
test test_minidom failed

@sethmlarson @gpshead

@gpshead gpshead merged commit ddcd2ac into python:3.13 Dec 5, 2025
73 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants