-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-143602: Fix duplicate buffer exports in io.BytesIO.write #143629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix a inconsistency issue in io.BytesIO.write() where the buffer was exported twice, which could lead to unexpected data overwrites and position drift when the buffer changes between exports.
vstinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The NEWS entry can be enhanced, but I cannot propose a better description.
|
Thanks @superboy-zjc for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @superboy-zjc for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @superboy-zjc and @vstinner, I could not cleanly backport this to |
|
Sorry, @superboy-zjc and @vstinner, I could not cleanly backport this to |
|
GH-143872 is a backport of this pull request to the 3.14 branch. |
|
I backported the change to 3.14: #143872. |
|
Merged, thanks for your contribution @superboy-zjc. |
…thon#143629) Fix an inconsistency issue in io.BytesIO.write() where the buffer was exported twice, which could lead to unexpected data overwrites and position drift when the buffer changes between exports. (cherry picked from commit c461aa9)
|
LGTM. 👍 |
…143629) (#143872) gh-143602: Fix duplicate buffer exports in io.BytesIO.write (#143629) Fix an inconsistency issue in io.BytesIO.write() where the buffer was exported twice, which could lead to unexpected data overwrites and position drift when the buffer changes between exports. (cherry picked from commit c461aa9) Co-authored-by: zhong <[email protected]>
|
Fix a inconsistency issue in io.BytesIO.write() where the buffer was exported twice, which could lead to unexpected data overwrites and position drift when the buffer changes between exports.