-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Add regression test for add() after remove() with hash collision in set #143781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
serhiy-storchaka
merged 1 commit into
python:main
from
serhiy-storchaka:test_hash_collision_remove_add
Jan 15, 2026
Merged
Add regression test for add() after remove() with hash collision in set #143781
serhiy-storchaka
merged 1 commit into
python:main
from
serhiy-storchaka:test_hash_collision_remove_add
Jan 15, 2026
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2026
rhettinger
approved these changes
Jan 15, 2026
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 15, 2026
…et (pythonGH-143781) (cherry picked from commit 565685f6e88fd333326baff6469f53cfff28e01e) Co-authored-by: Serhiy Storchaka <[email protected]>
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-143858 is a backport of this pull request to the 3.14 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jan 15, 2026
…on in set (pythonGH-143781) (cherry picked from commit 565685f) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jan 15, 2026
…on in set (pythonGH-143781) (cherry picked from commit 565685f) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-143859 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will catch possible regressions like in #142007.
Just for the case, added also a similar test for dict.