Skip to content

bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__iter__ #23534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 3 commits into from
Nov 30, 2020
Merged

bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__iter__ #23534

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9aa564d
Do not call __getitem__ on underlying maps in ChainMap.__iter__
ap-- Nov 28, 2020
48aa670
Add test for ChainMap.__iter__
ap-- Nov 28, 2020
e732767
Add blurb
ap-- Nov 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/collections/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,7 @@ def __len__(self):
def __iter__(self):
d = {}
for mapping in reversed(self.maps):
d.update(mapping) # reuses stored hash values if possible
d.update(dict.fromkeys(mapping)) # reuses stored hash values if possible
return iter(d)

def __contains__(self, key):
Expand Down