gh-79009: sqlite3.iterdump now correctly handles tables with autoincrement #9621

itssme · 2018-09-28T13:04:25Z

The iterdump command in Lib/sqlite3/dump.py assumed that the table "sqlite_sequence" already exists. When this was not the case and exception was thrown.

Changes:

Sqlite3 iterdump now deletes and recreates the "sqlite_sequence" table at the end of the transaction (Just like the sqlite3 command ".dump" does)
Added two new test for the iterdump command

Resolves gh-79009

…ement The iterdump command in Lib/sqlite3/dump.py assumed that the table "sqlite_sequence" already exists. When this was not the case and exception was thrown.

the-knights-who-say-ni · 2018-09-28T13:04:28Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

j0hax · 2021-06-24T12:56:53Z

Hello, it seems that I stumbled upon this bug today with Python 3.6.13. Are there any news as to a fix?

itssme · 2021-06-24T13:05:52Z

I saw that recently the unit tests of sqlite3 Lib/sqlite3/test/dump.py were changed, 849e339#diff-641ffce15acf9f552596b6192c714f53590980dba32625057918b53a9676f9ae
I will update my PR soon.

erlend-aasland · 2021-06-24T13:09:02Z

I saw that recently the unit tests of sqlite3 Lib/sqlite3/test/dump.py were changed, 849e339#diff-641ffce15acf9f552596b6192c714f53590980dba32625057918b53a9676f9ae
I will update my PR soon.

Thanks! ~~Please also sign the CLA before we can do a review.~~

https://devguide.python.org/pullrequest/

# Conflicts: # Lib/sqlite3/test/dump.py

…es according to PEP 8

Misc/NEWS.d/next/Library/2018-09-28-22-18-03.bpo-34828.5Zyi_S.rst

Lib/sqlite3/test/dump.py

itssme · 2021-07-22T11:20:00Z

I will make the requested changes as soon as I am home from my holidays 👍. Right now the internet is so slow, I cannot clone the project

# Conflicts: # Lib/sqlite3/test/test_dump.py

…qlite3 dump tests

erlend-aasland

Thanks for updating your PR :) I've left some comments.

Lib/sqlite3/dump.py

Lib/sqlite3/test/test_dump.py

erlend-aasland · 2022-05-19T22:26:32Z

@itssme, do you plan to follow up this PR?

itssme · 2022-05-20T11:59:12Z

Thanks for the reminder, yes I will update it this weekend 👍

…l as small formatting changes in sqlite3/dump.py

ghost · 2022-05-22T20:33:19Z

All commit authors signed the Contributor License Agreement.

erlend-aasland · 2022-05-25T07:25:39Z

@itssme, I won't have time to look at this for a week or two, but it is on my list :)

erlend-aasland

Thanks for doing this!

I think the tests can be simplified; the posts table is not really needed to test this functionality, so I suggest to drop it, in order to narrow down the tests.

In test_dump_autoincrement_create_new_db, one test table should be sufficient, right?

I also got some style nits; do you mind if I just apply them before merge?

Lib/test/test_sqlite3/test_dump.py

…xed wrong use of double quotes and single quotes in sqlite3 statements

itssme · 2022-06-17T22:43:32Z

I removed the posts table, renamed the tags table to t1 and simplified it. These were the tables from the database, where I first discovered the issue.

itssme · 2022-06-18T12:45:03Z

I also got some style nits; do you mind if I just apply them before merge?

Yes please, feel free to make any changes 👍

erlend-aasland · 2022-06-18T17:41:59Z

Thanks! I'll review the changes this coming week.

- consolidate construction of sqlite_sequence - use existing quoting style

- reduce number of escape chars in string literals - normalise variable names - in test_dump_autoincrement_create_new_db, simplify setup - use subTest in order to make it easier to assert more thoroughly

miss-islington · 2022-06-19T22:59:27Z

Thanks @itssme for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot · 2022-06-19T22:59:36Z

GH-94014 is a backport of this pull request to the 3.11 branch.

bedevere-bot · 2022-06-19T22:59:39Z

GH-94015 is a backport of this pull request to the 3.10 branch.

erlend-aasland · 2022-06-19T23:01:19Z

Thank you so much for the report, the fix, and your patience, @itssme! Unfortunately this took way too long to land, but at last the fix is on its way to the upcoming Python 3.12, 3.11, and 3.10 releases.

Thanks again!

bpo-34828 sqlite3.iterdump now correctly handles tables with autoincr…

9bf9eb7

…ement The iterdump command in Lib/sqlite3/dump.py assumed that the table "sqlite_sequence" already exists. When this was not the case and exception was thrown.

the-knights-who-say-ni added the CLA not signed label Sep 28, 2018

bedevere-bot added the awaiting review label Sep 28, 2018

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Sep 28, 2018

bpo-34828: added entry in NEWS.d/next/Library and in ACKS

5d7b0ae

itssme added 2 commits July 3, 2021 19:56

Merge remote-tracking branch 'origin/master' into fix-issue-34828

1ac20b0

# Conflicts: # Lib/sqlite3/test/dump.py

bpo-34828 Removed redundant code and made some small formatting chang…

365a2f1

…es according to PEP 8

itssme requested a review from berkerpeksag as a code owner July 3, 2021 18:38

erlend-aasland requested changes Jul 15, 2021

View reviewed changes

Misc/NEWS.d/next/Library/2018-09-28-22-18-03.bpo-34828.5Zyi_S.rst Outdated Show resolved Hide resolved

Lib/sqlite3/test/dump.py Show resolved Hide resolved

Lib/sqlite3/test/dump.py Outdated Show resolved Hide resolved

bedevere-bot added awaiting core review and removed awaiting review labels Jul 15, 2021

itssme added 2 commits October 16, 2021 01:04

Merge branch 'main' into fix-issue-34828

7c5901b

# Conflicts: # Lib/sqlite3/test/test_dump.py

bpo-34828 formatting changes as well as readability improvements in s…

b259219

…qlite3 dump tests

itssme requested a review from erlend-aasland October 17, 2021 13:54

erlend-aasland requested changes Oct 19, 2021

View reviewed changes

itssme mannequin mentioned this pull request May 16, 2022

sqlite.iterdump does not work for (most) databases with autoincrement #79009

Closed

itssme added 2 commits May 22, 2022 21:49

Merge branch 'main' into fix-issue-34828

3812bf6

bpo-34828: reformatted some tests in test_sqlite3/test.dump.py as wel…

daed6e5

…l as small formatting changes in sqlite3/dump.py

erlend-aasland changed the title ~~bpo-34828 sqlite3.iterdump now correctly handles tables with autoincrement~~ gh-79009: sqlite3.iterdump now correctly handles tables with autoincrement Jun 9, 2022

Merge branch 'main' into fix-issue-34828

d5daa91

erlend-aasland reviewed Jun 9, 2022

View reviewed changes

Lib/test/test_sqlite3/test_dump.py Outdated Show resolved Hide resolved

bpo-34828: minified test case for some sqlite3 dump command tests, fi…

4e573e9

…xed wrong use of double quotes and single quotes in sqlite3 statements

erlend-aasland added 5 commits June 19, 2022 23:03

Merge branch 'main' into fix-issue-34828

64f4101

Clean up dump.py

1abc7d0

- consolidate construction of sqlite_sequence - use existing quoting style

Cleanup: don't use abbreviated link in NEWS entry

6bfac7e

Cleanup: tests

103c50f

- reduce number of escape chars in string literals - normalise variable names - in test_dump_autoincrement_create_new_db, simplify setup - use subTest in order to make it easier to assert more thoroughly

Fix 1abc7d0

53076e9

erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jun 19, 2022

erlend-aasland approved these changes Jun 19, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Jun 19, 2022

erlend-aasland merged commit affa9f2 into python:main Jun 19, 2022

bedevere-bot removed the awaiting merge label Jun 19, 2022

bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 19, 2022

bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 19, 2022

Uh oh!

gh-79009: sqlite3.iterdump now correctly handles tables with autoincrement #9621

gh-79009: sqlite3.iterdump now correctly handles tables with autoincrement #9621

Conversation

itssme commented Sep 28, 2018 • edited by erlend-aasland Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Sep 28, 2018

Uh oh!

j0hax commented Jun 24, 2021

Uh oh!

itssme commented Jun 24, 2021

Uh oh!

erlend-aasland commented Jun 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

itssme commented Jul 22, 2021

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented May 19, 2022

Uh oh!

itssme commented May 20, 2022

Uh oh!

ghost commented May 22, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented May 25, 2022

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

itssme commented Jun 17, 2022

Uh oh!

itssme commented Jun 18, 2022

Uh oh!

erlend-aasland commented Jun 18, 2022

Uh oh!

miss-islington commented Jun 19, 2022

Uh oh!

bedevere-bot commented Jun 19, 2022

Uh oh!

bedevere-bot commented Jun 19, 2022

Uh oh!

erlend-aasland commented Jun 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

itssme commented Sep 28, 2018 •

edited by erlend-aasland

Loading

erlend-aasland commented Jun 24, 2021 •

edited

Loading

ghost commented May 22, 2022 •

edited by ghost

Loading