gh-96142: add missing params to dataclass._DataclassParams
#96382
Conversation
I think "include all the parameters" is a pretty defensible position too. |
ericvsmith
left a comment
ericvsmith
left a comment
There was a problem hiding this comment.
This is all great. Thanks! With the one nit about a comment, I'll accept this.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
|
Done! I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @ericvsmith: please review the changes made to this pull request. |
ericvsmith
left a comment
ericvsmith
left a comment
There was a problem hiding this comment.
There are some trailing spaces that are causing CI failures. I haven't actually checked every line for trailing whitespace, just the ones I quickly found (I'm working on checking out the code, but you can probably check faster than my connection can clone the code).
Lib/test/test_dataclasses.py
Outdated
|
|
||
| def test_dataclass_params_repr(self): | ||
| # Even though this is testing an internal implementation detail, | ||
| # it's testing a feature we want to make sure is correctly implemented |
There was a problem hiding this comment.
There's a trailing space on this line that is causing a CI failure.
Lib/test/test_dataclasses.py
Outdated
|
|
||
| def test_dataclass_params_signature(self): | ||
| # Even though this is testing an internal implementation detail, | ||
| # it's testing a feature we want to make sure is correctly implemented |
There was a problem hiding this comment.
Same thing here with a trailing space.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks everyone! |
5 participants
I went with explicit
.__dataclass_params__attribute access instead ofgetattr(klass, _PARAMS)because it felt more safe and concete to me.I've also considered
kw_onlyargument by @da-woods, but it feels like_DataclassParamsstructure must just hold passed arguments without much logic in it. It is up to the caller to inspectkw_onlyon class/field.match_args,slotsand possiblykw_onlymissing from__dataclass_params__#96142