Skip to content

Add _interpqueues for 3.13 #12240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 6 commits into from
Jul 4, 2024
Merged

Add _interpqueues for 3.13 #12240

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
267b71d
Add _interpqueues for 3.13
max-muoto Jun 30, 2024
78057cf
Add to VERSIONS
max-muoto Jun 30, 2024
d53f42e
Merge branch 'main' into add-_interpqueues-3.13
max-muoto Jul 3, 2024
a77bcf8
Address comment
max-muoto Jul 4, 2024
98a79ac
Move to Any
max-muoto Jul 4, 2024
42218c7
Merge branch 'main' into add-_interpqueues-3.13
max-muoto Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stdlib/VERSIONS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ _dummy_threading: 3.0-3.8
_heapq: 3.0-
_imp: 3.0-
_interpchannels: 3.13-
_interpqueues: 3.13-
_json: 3.0-
_locale: 3.0-
_lsprof: 3.0-
Expand Down
16 changes: 16 additions & 0 deletions stdlib/_interpqueues.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
from typing import SupportsIndex

class QueueError(RuntimeError): ...
class QueueNotFoundError(QueueError): ...
Copy link
Copy Markdown
Collaborator

@srittau srittau Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There also QueueEmpty and QueueFull:

https://github.com/python/cpython/blob/722229e5dc1e499664966e50bb98065670033300/Modules/_interpqueuesmodule.c#L158-L159

Copy link
Copy Markdown
Contributor Author

@max-muoto max-muoto Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing these actually get exported, might be because of:

// QueueEmpty and QueueFull are set by set_external_exc_types().
state->QueueEmpty = NULL;
state->QueueFull = NUL

3.13.0b2

>>> import _interpqueues as iq
>>> iq.QueueEmpty
Traceback (most recent call last):
  File "<python-input-5>", line 1, in <module>
    iq.QueueEmpty
AttributeError: module '_interpqueues' has no attribute 'QueueEmpty'
>>> iq.QueueFull
Traceback (most recent call last):
  File "<python-input-6>", line 1, in <module>
    iq.QueueFull
AttributeError: module '_interpqueues' has no attribute 'QueueFull'
>>>


def bind(qid: SupportsIndex) -> None: ...
def create(maxsize: SupportsIndex, fmt: SupportsIndex) -> int: ...
def destroy(qid: SupportsIndex) -> None: ...
def get(qid: SupportsIndex) -> tuple[object, int]: ...
Comment thread
srittau marked this conversation as resolved.
Outdated
def get_count(qid: SupportsIndex) -> int: ...
def get_maxsize(qid: SupportsIndex) -> int: ...
def get_queue_defaults(qid: SupportsIndex) -> tuple[int]: ...
def is_full(qid: SupportsIndex) -> bool: ...
def list_all() -> list[tuple[int, int]]: ...
def put(qid: SupportsIndex, obj: object, fmt: SupportsIndex) -> None: ...
Copy link
Copy Markdown
Collaborator

@srittau srittau Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly (which I might not), the allowed values for obj depend on fmt. This would mean either using overloads or – easiest for now – Any for obj.

Copy link
Copy Markdown
Contributor Author

@max-muoto max-muoto Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does using Any versus object really serve much of an advantage for param like this?

Copy link
Copy Markdown
Collaborator

@srittau srittau Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mainly a documentation thing: "We can't accurately type this argument" instead of "this argument accepts all possible values" (like for example str() does).

Copy link
Copy Markdown
Contributor Author

@max-muoto max-muoto Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, makes sense.

Copy link
Copy Markdown
Contributor Author

@max-muoto max-muoto Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep things simple for now that in this case, and we can see about adding the overloads in a follow-up.

Copy link
Copy Markdown
Contributor Author

@max-muoto max-muoto Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

98a79ac

def release(qid: SupportsIndex) -> None: ...