Skip to content

marshal: improve bytes handling #9047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 4 commits into from
Oct 31, 2022
Merged

marshal: improve bytes handling #9047

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f791ce0
marshal: improve bytes handling
sobolevn Oct 31, 2022
f316f1e
Update stdlib/marshal.pyi
sobolevn Oct 31, 2022
93176a7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 31, 2022
724c330
Update marshal.pyi
sobolevn Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions stdlib/marshal.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
from typing import IO, Any
from _typeshed import ReadableBuffer

@JelleZijlstra JelleZijlstra Oct 31, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from _typeshed import ReadableBuffer
from _typeshed import ReadableBuffer, SupportsRead, SupportsWrite

@JelleZijlstra JelleZijlstra Oct 31, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you just did that, thanks! GitHub's UI doesn't handle this well: the "Commit" button still shows up on the suggestion but clicking it does nothing. :)

@sobolevn sobolevn Oct 31, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done ;)

from typing import Any

version: int

def dump(__value: Any, __file: IO[Any], __version: int = ...) -> None: ...
def load(__file: IO[Any]) -> Any: ...
def dump(__value: Any, __file: SupportsWrite[bytes], __version: int = ...) -> None: ...
def load(__file: SupportsRead[bytes]) -> Any: ...
def dumps(__value: Any, __version: int = ...) -> bytes: ...
def loads(__bytes: bytes) -> Any: ...
def loads(__bytes: ReadableBuffer) -> Any: ...