Skip to content

Conversation

@nil-is-all
Copy link
Contributor

No description provided.

…nzalezorlandoarm

Updated workflow to include scheduled runs and refine exclusion logic for bots and authors.
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16375

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 2 Unrelated Failures

As of commit 6e437aa with merge base 39203cf (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 23, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the GitHub workflow for adding unanswered external contributor PRs and issues to a PyTorch project by introducing automated cron schedules and improving bot/user exclusion logic.

  • Adds cron schedules to run the workflow twice daily at 8 AM and 1 PM Central Time
  • Introduces a new isBotOrExcluded function to centralize and improve bot/user filtering logic
  • Adds "tgonzalezorlandoarm" and "dependabot[bot]" to the exclusion list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

// Some bots use logins that end with [bot], e.g. dependabot[bot]
if (user.login && user.login.endsWith("[bot]")) return true;
// Explicit excluded list
if (excludedAuthors.has(user.login)) return true;
Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function checks user.login on line 66 without first verifying that user.login exists. While line 60 checks if user is truthy, if user exists but user.login is null/undefined, this could cause issues. Consider adding a check like "if (user.login && excludedAuthors.has(user.login))" for consistency with the bot login check on line 64.

Suggested change
if (excludedAuthors.has(user.login)) return true;
if (user.login && excludedAuthors.has(user.login)) return true;

Copilot uses AI. Check for mistakes.
@psiddh psiddh requested a review from mergennachin December 23, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants