-
Notifications
You must be signed in to change notification settings - Fork 776
Add cron schedule for 8 am CT & 1 pm CT, and exclude dependabot & tgonzalezorlandoarm #16375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nzalezorlandoarm Updated workflow to include scheduled runs and refine exclusion logic for bots and authors.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16375
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 2 Unrelated FailuresAs of commit 6e437aa with merge base 39203cf ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the GitHub workflow for adding unanswered external contributor PRs and issues to a PyTorch project by introducing automated cron schedules and improving bot/user exclusion logic.
- Adds cron schedules to run the workflow twice daily at 8 AM and 1 PM Central Time
- Introduces a new
isBotOrExcludedfunction to centralize and improve bot/user filtering logic - Adds "tgonzalezorlandoarm" and "dependabot[bot]" to the exclusion list
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Some bots use logins that end with [bot], e.g. dependabot[bot] | ||
| if (user.login && user.login.endsWith("[bot]")) return true; | ||
| // Explicit excluded list | ||
| if (excludedAuthors.has(user.login)) return true; |
Copilot
AI
Dec 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function checks user.login on line 66 without first verifying that user.login exists. While line 60 checks if user is truthy, if user exists but user.login is null/undefined, this could cause issues. Consider adding a check like "if (user.login && excludedAuthors.has(user.login))" for consistency with the bot login check on line 64.
| if (excludedAuthors.has(user.login)) return true; | |
| if (user.login && excludedAuthors.has(user.login)) return true; |
No description provided.