-
Notifications
You must be signed in to change notification settings - Fork 778
Integrate CUDA sampler into ASR runner and enable skip_copy for decoder #16388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
larryliu0820
wants to merge
1
commit into
gh/larryliu0820/88/head
Choose a base branch
from
gh/larryliu0820/89/head
base: gh/larryliu0820/88/head
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+111
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
larryliu0820
added a commit
that referenced
this pull request
Dec 24, 2025
- cuda_backend.cpp: Support comma-separated method names in skip_copy_output_to_cpu_for_method backend option. - runner.cpp: Use CudaSampler for argmax when CUDA is available and temperature==0. Skip copy to CPU for both encoder and decoder methods. - CMakeLists.txt updates: Link against extension_llm_sampler_cuda library and include the sampler subdirectory. This optimization keeps decoder logits on GPU and performs argmax directly on GPU memory, avoiding unnecessary device-to-host copies in the decode loop. ghstack-source-id: e3e85c9 ghstack-comment-id: 3688378475 Pull-Request: #16388
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16388
Note: Links to docs will display an error until the docs builds have been completed. ❌ 14 New Failures, 2 Unrelated FailuresAs of commit 1637ec1 with merge base c5d66a5 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip_copy_output_to_cpu_for_method backend option.
temperature==0. Skip copy to CPU for both encoder and decoder methods.
and include the sampler subdirectory.
This optimization keeps decoder logits on GPU and performs argmax directly
on GPU memory, avoiding unnecessary device-to-host copies in the decode loop.