Added nb-clean to pre-commit config#3618
Added nb-clean to pre-commit config#3618Prathamesh8989 wants to merge 2 commits intopytorch:masterfrom
Conversation
4299a05 to
37e8384
Compare
|
I have updated the Verification performed:
The configuration is clean and all CI checks are currently passing. CC: @vfdev-5 for review and merging. |
|
@vfdev-5 this pr looks good. |
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks @Prathamesh8989 and @aaishwarymishra !
|
Let's pass nb-clean on the codebase in this PR, squash all commits into one and add the commit into https://github.com/pytorch/ignite/blob/master/.git-blame-ignore-revs |
|
Thanks for the guidance! I’ll run nb-clean across the entire codebase in this PR, squash all commits into a single clean commit, and then add the resulting commit hash to .git-blame-ignore-revs as requested. Will update the PR shortly. 👍 |
a7d829c to
0c98ba1
Compare
0c98ba1 to
4a06130
Compare
4a06130 to
f547921
Compare
|
I have updated the PR with the following changes:
All CI checks are passing. Ready for review! @vfdev-5 @aaishwarymishra |
I think you kinda got it wrong you have to squash all commits in one add the new commit hash to |
Co-authored-by: Aaishwarya Mishra <aaishwarymishra@gmail.com>
|
Thanks @aaishwarymishra! I've accepted the suggestion and updated the hash in .git-blame-ignore-revs. Everything should be aligned now. |
|
@Prathamesh8989 the code style check is failed, please take a look |
|
@Prathamesh8989 I ran pre-commit hook in your branch and pre-commit still modified files. rerun the pre-commit squash commits and add it to .git-blame-ignore-revs |
This is a fresh PR to replace #3585, ensuring a clean commit history as requested.
Changes:
nb-cleanas the first hook to strip notebook outputs before formatting.CC: @aaishwarymishra