Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

Update reference to torch::TypeError#72

Open
mehtanirav wants to merge 2 commits into
pytorch:mainfrom
mehtanirav:nirav_update_torcherror
Open

Update reference to torch::TypeError#72
mehtanirav wants to merge 2 commits into
pytorch:mainfrom
mehtanirav:nirav_update_torcherror

Conversation

@mehtanirav
Copy link
Copy Markdown

@mehtanirav mehtanirav commented Jan 4, 2023

What does this PR do? Please describe:
Following the changes in pytorch/pytorch#87855, we want to update references to torch:TypeError to TORCH_CHECK_TYPE. The changes are already made to fbcode in internal diff

Fixes #{issue number}

Does your PR introduce any breaking changes? If yes, please list them:
List of all backwards-incompatible API changes.

Check list:

  • Was this discussed and approved via a GitHub issue? (not for typos or docs)
  • Did you read the contributor guideline?
  • Did you make sure that your PR does only one thing instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, or minor internal changes)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 4, 2023
@cbalioglu
Copy link
Copy Markdown
Contributor

@mehtanirav Thanks for the PR! Looks good to me. For some reason clang-tidy is complaining about code complexity in an unrelated part of the code base. Do you mind disabling readability-function-cognitive-complexity check in the .clang-tidy file at the root of the repo? I can do it, but that would require you to rebase your work. It might be easier to do it as part of this PR.

@facebook-github-bot
Copy link
Copy Markdown

Hi @mehtanirav!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants