Fix composite pass missing captured values in ops with nested regions#9760
Open
mstojkovicTT wants to merge 2 commits intopytorch:masterfrom
Open
Fix composite pass missing captured values in ops with nested regions#9760mstojkovicTT wants to merge 2 commits intopytorch:masterfrom
mstojkovicTT wants to merge 2 commits intopytorch:masterfrom
Conversation
Author
|
Tagging @qihqi and @ysiraichi for visibility |
Collaborator
|
Could you add some tests that show the failure? The build failure is detailed in this comment. |
qihqi
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
BuildStableHLOCompositePassperforms a reverse graph traversal from output boundary markers to input boundary markers to collect all ops that belong to a composite. The traversal followedop->getOperands()to discover dependencies, but this only captures values passed directly to an op, and it misses values that are used inside nested regions (e.g., the body of astablehlo.reduce) but defined in the parent function.This caused the generated composite impl function to reference values that were never included as arguments or cloned ops, leading to invalid MLIR.
Fix
After processing each op's direct operands, the traversal now also inspects all nested regions using
mlir::getUsedValuesDefinedAbove()(mlir doc) to find captured values. These are handled with the same logic as direct operands: