Update XRImage to create missing 'bands' coordinate when dimension is present#197
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
+ Coverage 91.63% 91.77% +0.13%
==========================================
Files 11 12 +1
Lines 4114 4135 +21
==========================================
+ Hits 3770 3795 +25
+ Misses 344 340 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mraspaud
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was created due to a conversation with @gerritholl about some test datasets in Satpy. The summary is that the test datasets had a "bands" dimension but no
data_arr.coords["bands"]entry. Once a call to.squeezewas removed (it had been masking this issue), the enhancement/stretch methods inXRImagewere breaking because xarray was defaultingdata_arr.coords["bands"]to an integer array of 0. XRImage expects a list of strings (ex.["R", "G", "B"].git diff origin/master **/*py | flake8 --diff(remove if you did not edit any Python files)