Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 47.94% 50.59% +2.64%
==========================================
Files 5 4 -1
Lines 390 253 -137
Branches 58 34 -24
==========================================
- Hits 187 128 -59
+ Misses 180 112 -68
+ Partials 23 13 -10
Continue to review full report at Codecov.
|
Member
Author
|
Seems like there is an issue with the C-API in 3.11 Will have to dig in more to update to be compatible. |
Member
Author
|
This 3.11 issue looks like it might be involved, or at least it goes beyond my immediate expertise. I'm going to open an issue and hope that someone can help here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for the 3.5.2 patch release, which shouldn't have any impact on the functionality of the library. I'm simply upgrading the build and CI infrastructure to match templated patterns I'm defining in "xcookie" (which is still fairly hard coded and not ready for general consumption, but using it on this repo will help remove some of that boilerplate).
This is motivated by preparing builds for the 3.11 release. While I'm messing with the internals, I may add a readthedocs page and doctests.