Skip to content

Update build process#157

Merged
Erotemic merged 8 commits intomainfrom
dev/3.5.2
Sep 12, 2022
Merged

Update build process#157
Erotemic merged 8 commits intomainfrom
dev/3.5.2

Conversation

@Erotemic
Copy link
Member

This PR is for the 3.5.2 patch release, which shouldn't have any impact on the functionality of the library. I'm simply upgrading the build and CI infrastructure to match templated patterns I'm defining in "xcookie" (which is still fairly hard coded and not ready for general consumption, but using it on this repo will help remove some of that boilerplate).

This is motivated by preparing builds for the 3.11 release. While I'm messing with the internals, I may add a readthedocs page and doctests.

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #157 (fcf6a3c) into main (fbac588) will increase coverage by 2.64%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   47.94%   50.59%   +2.64%     
==========================================
  Files           5        4       -1     
  Lines         390      253     -137     
  Branches       58       34      -24     
==========================================
- Hits          187      128      -59     
+ Misses        180      112      -68     
+ Partials       23       13      -10     
Impacted Files Coverage Δ
line_profiler/line_profiler.py 52.24% <100.00%> (ø)
kernprof.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbac588...fcf6a3c. Read the comment docs.

@Erotemic
Copy link
Member Author

Erotemic commented Sep 8, 2022

Seems like there is an issue with the C-API in 3.11

        /project/_skbuild/linux-x86_64-3.11/cmake-build/line_profiler/_line_profiler.c: In function ‘__pyx_f_13line_profiler_14_line_profiler_python_trace_callback’:
        /project/_skbuild/linux-x86_64-3.11/cmake-build/line_profiler/_line_profiler.c:5688:46: error: invalid use of incomplete typedef ‘PyFrameObject’ {aka ‘struct _frame’}
         5688 |     __pyx_t_1 = ((PyObject *)__pyx_v_py_frame->f_code);
              |                                              ^~
        /project/_skbuild/linux-x86_64-3.11/cmake-build/line_profiler/_line_profiler.c:5896:58: error: invalid use of incomplete typedef ‘PyFrameObject’ {aka ‘struct _frame’}
         5896 |         __pyx_t_1 = __Pyx_PyInt_From_int(__pyx_v_py_frame->f_lineno); if (unlikely(!__pyx_t_1)) __PYX_ERR(0, 218, __pyx_L1_error)
              |                                                          ^~

Will have to dig in more to update to be compatible.

@Erotemic
Copy link
Member Author

This 3.11 issue looks like it might be involved, or at least it goes beyond my immediate expertise. I'm going to open an issue and hope that someone can help here.

@Erotemic Erotemic merged commit 9afaed2 into main Sep 12, 2022
@Erotemic Erotemic deleted the dev/3.5.2 branch August 12, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant