Generic printf function does not implement microsoft specifiers

[kbsec]

*Describe the bug
The implementation of printf/wprintf has incorrect behavior when used for windows.
see documentation here:
https://learn.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions?view=msvc-170

If I have time in the next few weeks, I'll submit a pr :)
Sample Code

#include <windows.h>
#include <stdio.h> 

# define W 

int main(){
  // https://learn.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions?view=msvc-170
  // The windows implementation of printf/wprintf 
  // type field characters does not confirm to ISO C stanards 
  // In particular, the behavior of %s/%S is differnt depending on 
  // on wether printf/wprintf is called 
  #ifdef W
  wprintf(L"I am a C string %s\n", "hello world!");
  wprintf(L"I amd a Wide C string %s\n", L"hello world!");
  #else 
  printf("I am a C string %s\n", "hello world!");
  printf("I amd a Wide C string %S\n", L"hello world!");
  #endif 

}

 x86_64-w64-mingw32-gcc windows_printf.c -DW -o wprintf.exe
 x86_64-w64-mingw32-gcc windows_printf.c  -o printf.exe

Expected behavior
wine64 wprintf.exe
I am a C string hello world!
I amd a Wide C string h

wine64 printf.exe
I am a C string hello world!
I amd a Wide C string hello world!

Screenshots

Additional context
Add any other context about the problem here.

[kbsec]

Looks like y'all are aware:

qiling/qiling/os/utils.py

Lines 129 to 142 in 9a78d18

	# https://docs.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions
	# %[flags][width][.precision][size]type
	fmtstr = re.compile(r'''%
	(?P<follows>%|
	(?P<flags>[-+0 #]+)?
	(?P<width>[*]|[0-9]+)?
	(?:.(?P<precision>[*]|[0-9]+))?
	(?P<size>hh|ll|I32|I64|[hjltwzIL])?
	(?P<type>[diopuaAcCeEfFgGsSxXZ])
	)
	''', re.VERBOSE)
	T = TypeVar('T')

PS C:\vagrant> .\printf.exe
I am a C string hello world!
I amd a Wide C string hello world!
PS C:\vagrant> .\wprintf.exe
I am a C string hello world!
I amd a Wide C string h
PS C:\vagrant> 

./qltool run --verbose off  --rootfs rootfs/x8664_windows -f rootfs/x8664_windows/bin/wprintf.exe
./qltool run --verbose off  --rootfs rootfs/x8664_windows -f rootfs/x8664_windows/bin/printf.exe

both of these lead to issues with strings being misinterpreted
one work around for now is to hook wprintf and swap %s-->%ls and %S --> %s and then call printf

[elicn]

The link you provided for the screenshot circles back to this issue, so we can't see it the problem. If this is about handling %S as wide strings, that should be an easy fix.

[kbsec]

Ah my fault:

it is just for handling %s vs %S for wprintf :)
Namely,

wprintf(L"Hello  %S", "world"); // notice "world" instead of L"world"
wprintf(L"Hello %s", L"world"); // notice L"world" instead of "world"

[elicn]

Should be fixed now. Please let us know if the problem persists.