Merged
Conversation
kabeor
reviewed
Jul 21, 2022
| ERROR_PATH_NOT_FOUND = 0x3 | ||
| ERROR_ACCESS_DENIED = 0x5 | ||
| ERROR_INVALID_HANDLE = 0x6 | ||
| ERROR_GEN_FAILURE = 0x1f |
Member
There was a problem hiding this comment.
I think here should be capitalized?
Member
Author
There was a problem hiding this comment.
I don't think we have a consistent convention for that (there are many lowercase and upercase constans everywhere), neither PEP8 defines it. Is there are specific reason here?
Member
There was a problem hiding this comment.
No, I just saw the variables that existed before is all uppercase values.
kabeor
approved these changes
Jul 26, 2022
xwings
approved these changes
Jul 26, 2022
wtdcode
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights: