Fix bug: qdb load address error#1364
Merged
elicn merged 1 commit intoqilingframework:devfrom Jul 13, 2023
Merged
Conversation
…l.run(begin=0x1234)
kabeor
approved these changes
Jul 11, 2023
elicn
approved these changes
Jul 12, 2023
Member
|
@ucgJhe, wanna take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug: Using ql.run(begin=myaddr) but qdb executes from the entry point of the binary.
Example
When use
But it should be
Reason
The "begin" parameter is stored in ql.entry_point, but qdb loads only ql.loader.entry_point, and ql.loader.entry_point points to the entry point of the binary
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Target branch?