Fix overflow with wait options#1413
Merged
xwings merged 1 commit intoqilingframework:devfrom Dec 14, 2023
Ninja3047:fix-wait-overflow
Merged
Fix overflow with wait options#1413xwings merged 1 commit intoqilingframework:devfrom Ninja3047:fix-wait-overflow
xwings merged 1 commit intoqilingframework:devfrom
Ninja3047:fix-wait-overflow
Conversation
python expects options to be a signed 32bit integer
elicn
approved these changes
Dec 4, 2023
xwings
approved these changes
Dec 14, 2023
Member
|
Thanks and welcome to Qiling Framework |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python expects options to be a signed 32bit integer. The current code will throw the following error in Python when emulating the wait4 syscall with the
__WCLONEoption (0x80000000).if I debug the Python implementation of
os.wait4, we can see that the error is thrown here when it tries to get the option argumentChecklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing