Bugfix: unaligned access in MIPS getdents64#1419
Merged
xwings merged 1 commit intoqilingframework:devfrom Dec 14, 2023
Merged
Conversation
Member
|
Hi, Welcome to Qiling Framework. Your PC need to to merge to dev and not master. thanks |
Member
|
Hi, The code seems to break the test. I need to revert it. Will you be able to make another PR ? |
Contributor
Author
|
I have run the tests and they pass on my end, should I create a new PR? |
Member
|
Its better for a new PR and let it run thru the test. let the rest of the team comment it too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing