Fix logging issues caused by IDA custom stderr#1493
Merged
xwings merged 1 commit intoqilingframework:devfrom Nov 25, 2024
Merged
Fix logging issues caused by IDA custom stderr#1493xwings merged 1 commit intoqilingframework:devfrom
xwings merged 1 commit intoqilingframework:devfrom
Conversation
15 tasks
xwings
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDA replaces
sys.stderrwith their own custom class that is not fully compatible with standard stream protocol, which causes Qiling to not detect it as a valid logging device and crash. This PR fixes this issue by monkeypatching IDA stderr to make it look like a standard stream.