Changed member welcome email job to run based on config#16
Conversation
🤖 Augment PR SummarySummary: Move member welcome-email enablement from a Labs flag to a config-driven “test inbox” setting. Changes:
Technical Notes: Behavior is now controlled by the presence of a configured inbox value. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (!hasScheduled.processOutbox && !process.env.NODE_ENV.startsWith('test')) { | ||
| if (hasScheduled.processOutbox && !process.env.NODE_ENV.startsWith('test')) { |
There was a problem hiding this comment.
hasScheduled.processOutbox looks inverted here: since it starts as false and is only set to true inside this block, this condition prevents the job from ever being scheduled. Was this meant to be !hasScheduled.processOutbox to ensure it schedules once?
🤖 Was this useful? React with 👍 or 👎
| if (this._labsService.isSet('welcomeEmails') && WELCOME_EMAIL_SOURCES.includes(source)) { | ||
| var member; | ||
| const welcomeEmailConfig = config.get('memberWelcomeEmailTestInbox'); | ||
| if (welcomeEmailConfig || WELCOME_EMAIL_SOURCES.includes(source)) { |
There was a problem hiding this comment.
This if (welcomeEmailConfig || WELCOME_EMAIL_SOURCES.includes(source)) will create an outbox entry even when the config is unset (for allowed sources), and also for all sources when the config is set. That seems to contradict the tests below which expect no outbox entry when config is not set and for imported/admin contexts.
🤖 Was this useful? React with 👍 or 👎
2 participants
Benchmark PR from qodo-benchmark#246