Reduced volume of network requests on Web traffic views#8
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements lazy loading for filter options in the stats views to reduce the volume of network requests. Instead of fetching all filter options upfront, the implementation now only fetches options for filters when they are actively being selected or when they have an applied value (to display labels correctly).
Changes:
- Added lazy loading mechanism for filter options using an
enabledconfiguration parameter - Enhanced the Filters component to notify parent components when a filter field becomes active
- Integrated loading states throughout the filter UI components
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/stats/src/views/Stats/components/stats-filter.tsx | Implements lazy loading for filter options with active field tracking and loading states |
| apps/shade/src/components/ui/filters.tsx | Adds onActiveFieldChange callback to notify parent when filter field selection changes |
| apps/posts/src/views/PostAnalytics/components/stats-filter.tsx | Implements lazy loading for filter options with active field tracking and loading states |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#94